Skip to content

poc: make cat-blocks a configurable theme #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

poc: make cat-blocks a configurable theme #374

wants to merge 1 commit into from
+9 −2

Conversation

@KManolov3
Copy link
Contributor

@KManolov3 KManolov3 commented Nov 4, 2025 •
edited
Loading

Resolves

Part of spike related to https://scratchfoundation.atlassian.net/browse/UEPR-409

Proposed Changes

Pass useCatBlocks flag to Blockly, where it's to be used to optionally show the cat-blocks theme. Depend on using scratch-blocks version in scratchfoundation/scratch-blocks#3411. Set useCatBlocks to true when using the high-contrast theme to experiment with both:

  • switching cat-blocks on and off on the same page and
  • whether there'd be any negative interaction with the high-contrast blocks

Reason for Changes

This is a PoC to experiment with how hard it'd be to bring cat-blocks back as an optional theme

@KManolov3 KManolov3 requested a review from a team as a code owner November 4, 2025 15:14
@KManolov3 KManolov3 marked this pull request as draft November 4, 2025 15:16
@KManolov3 KManolov3 changed the title feat: make cat-blocks a configurable theme poc: make cat-blocks a configurable theme Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025 •
edited
Loading

Test report for scratch-gui

  2 files  ±0   62 suites  ±0   9m 50s ⏱️ +11s
398 tests ±0  390 ✅ ±0  8 💤 ±0  0 ❌ ±0 
416 runs  ±0  408 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit a33649e. ± Comparison against base commit 280cc00.

♻️ This comment has been updated with latest results.

adzhindzhi
adzhindzhi reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

@adzhindzhi adzhindzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! It does raise some UX questions, such as how we would toggle this on/off, where it would live in the UI, and whether we'd want to use it along with the high contrast theme (likely yes), etc. But that's not something we need to figure out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adzhindzhi adzhindzhi adzhindzhi left review comments

@cwillisf cwillisf Awaiting requested review from cwillisf

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KManolov3 @adzhindzhi